[harmony] Bug 2052697: Require Perl 5.14.0#168
Open
justdave wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
What it says on the tin. Thanks to unicode issues which were fixed in 5.14, our i18n requirements need us to require that.
Additional info
Test Plan
I used
grep -rl 'use 5.10.1;' * | xargs -n1 sed -i.sedbackup -e 's/^use 5.10.1;/use 5.14.0;/'to make the initial changes, and then manually poked things liket/002goodperl.tandMakefile.PLthat mentioned it in places other than the use line at the top.I manually reviewed the diff to insure those were the only things getting touched.
Other than making sure the site actually runs and getting some real-world testing out of it, there's not much else we can do to test this.